allow mixture components to override cache_dir #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
percyliang
reviewed
Oct 5, 2024
| @@ -788,10 +796,23 @@ def build_caches( | |||
| if weight == 0 and split == "train": | |||
| continue | |||
|
|
|||
| source_config_dict = source_config.__dict__ | |||
| source_config_dict = dict(**source_config.__dict__) | |||
There was a problem hiding this comment.
Add comment on why we need to delete it - to make the LMDatasetMixtureComponentConfig act like a LMDatasetSourceConfig?
There was a problem hiding this comment.
more or less. i also cleaned this part up a bit
percyliang
reviewed
Oct 5, 2024
src/levanter/data/text.py
Outdated
| @@ -524,13 +524,18 @@ def fsspec_expand_glob(url): | |||
| return urls | |||
|
|
|||
|
|
|||
| @dataclass | |||
| class LMDatasetMixtureComponentConfig(LMDatasetSourceConfig): | |||
There was a problem hiding this comment.
The only thing different between the base and derived class is cache_dir? Seems weird since this on the surface doesn't seem to relate to mixtures...
There was a problem hiding this comment.
yeah i can just put it in the base i guess
percyliang
approved these changes
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.